Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TBB quick test. #13466

Merged
merged 1 commit into from Mar 1, 2022
Merged

Fix the TBB quick test. #13466

merged 1 commit into from Mar 1, 2022

Conversation

drwells
Copy link
Member

@drwells drwells commented Feb 28, 2022

I fixed the test to avoid things not in the oneAPI version of TBB. Unfortunately this means the most recent release's quick tests don't work with oneAPI.

I'm worried that we somehow managed to put out a patch release (9.3.3) without ever running this quick test. In fact, I don't know where the CI actually runs the quick tests: we should make sure that happens at some point to avoid problems like this in the future.

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to fix the indentation. 🙂

This should work with or without oneAPI.
@drwells
Copy link
Member Author

drwells commented Mar 1, 2022

Credit goes to an AUR user (Alad) for the report:

https://aur.archlinux.org/packages/deal-ii#comment-854264

@marcfehling
Copy link
Member

marcfehling commented Mar 1, 2022

Our intel debug github actions worker builds the library with oneTBB.

It would be interesting to see if there will be an error with quicktests enabled in #13467 without this patch.
EDIT: In fact, the same error as in the AUR will be reported:

3/8 Test #4: tbb.debug ........................***Failed    4.41 sec
/home/runner/work/dealii/dealii/tests/quick_tests/tbb.cc(21): catastrophic error: cannot open source file "tbb/task_scheduler_init.h"
  #include <tbb/task_scheduler_init.h>
                                      ^
compilation aborted for /home/runner/work/dealii/dealii/tests/quick_tests/tbb.cc (code 4)

And also interesting to see if it goes away after this patch got merged (and #13467 got rebased).

@marcfehling marcfehling merged commit 7fef175 into dealii:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants