Use a valid communicator. #13471
Merged
Use a valid communicator. #13471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
reviewed
Mar 1, 2022
Comment on lines
-112
to
+114
| if (sub_comm != MPI_COMM_NULL) | ||
| if (sub_comm != MPI_COMM_SELF) |
There was a problem hiding this comment.
Thanks for tackling this!
I am not sure if this is equivalent to the previous code: this only works if MPI_COMM_WORLD and MPI_COMM_SELF are not the same (and if a subcommunicator of size one is not equivalent to MPI_COMM_SELF) for a serial execution. Is this the case?
There was a problem hiding this comment.
Right, good question. In this particular case, the test is only ever run with 4 processors, so I think this should work. I didn't mean to suggest that this is a generally good approach. I think a better approach would be to just not create a p::d::T object on the unused processes. But that seemed like more work.
|
Rebased. |
tamiko
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13469.
/rebuild