Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a template variable that can be used to query whether T is a natively supported MPI type. #13473

Merged
merged 5 commits into from Mar 4, 2022

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Mar 1, 2022

Building a bit of infrastructure that I then want to next use in std::enable_if clauses. This is in essence a C++20-style concept that we can at a later time use if we want to convert enable_if clauses into requires clauses.

/rebuild

@bangerth
Copy link
Member Author

bangerth commented Mar 3, 2022

Ping?

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@masterleinad
Copy link
Member

This reminded me of #12954 which does something very similar. I was surprised that that one was never finished, though.

@bangerth
Copy link
Member Author

bangerth commented Mar 4, 2022

If anyone would like to merge this, then I'll rebase #12954 on top and finish it off.

@bangerth
Copy link
Member Author

bangerth commented Mar 4, 2022

Optimizing MPI::broadcast was indeed what I wrote this for.

@masterleinad masterleinad merged commit 0fe3491 into dealii:master Mar 4, 2022
@bangerth bangerth deleted the is_mpi_type branch March 4, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants