Move p:d:T::has_hanging_nodes() to DistributedTriangulationBase #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Mar 3, 2022
| * Return true if the triangulation has hanging nodes. | ||
| * | ||
| * In the context of parallel distributed triangulations, every | ||
| * processor stores only that part of the triangulation it locally owns. |
There was a problem hiding this comment.
Pre-existing, but I think proper English grammar needs to spell this as
Suggested change
| * processor stores only that part of the triangulation it locally owns. | |
| * processor stores only that part of the triangulation it owns locally. |
Comment on lines
472
to
473
| * However, it also stores the entire coarse mesh, and to guarantee the | ||
| * 2:1 relationship between cells, this may mean that there are hanging |
There was a problem hiding this comment.
I think this needs to be modified because fullydistributed::Triangulation does not store the whole coarse mesh. I would phrase this in a way to say that we store a coarse mesh that in general covers a larger part of the computational domain than the locally owned or ghosted cells.
source/distributed/tria_base.cc
Outdated
Comment on lines
748
to
749
| return 0 < Utilities::MPI::max(have_coarser_cell ? 1 : 0, | ||
| this->mpi_communicator); |
There was a problem hiding this comment.
I think this gets easier to read if you move the constant part of the comparison to the right hand side,
Suggested change
| return 0 < Utilities::MPI::max(have_coarser_cell ? 1 : 0, | |
| this->mpi_communicator); | |
| return Utilities::MPI::max(have_coarser_cell ? 1 : 0, | |
| this->mpi_communicator) != 0; |
There was a problem hiding this comment.
| this->mpi_communicator); | ||
| } | ||
|
|
||
|
|
|
/rebuild |
bangerth
reviewed
Mar 3, 2022
peterrum
force-pushed
the
pft_has_hanging_nodes
branch
from
b5efb9f
to
bab3b0f
Compare
|
@kronbichler I have made the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... since the logic is the same as for
p:f:T.