GC: enable inplace operation for coarse side #13494
Conversation
| if (mg_level_coarse == numbers::invalid_unsigned_int) | ||
| DoFTools::extract_locally_relevant_dofs(dof_handler_coarse, | ||
| locally_relevant_dofs); | ||
| else | ||
| DoFTools::extract_locally_relevant_level_dofs( | ||
| dof_handler_coarse, mg_level_coarse, locally_relevant_dofs); |
There was a problem hiding this comment.
This is a bit too conservative. I have changed it to active DoFs plus constraining DoFs.
peterrum
force-pushed
the
use_src_inplace
branch
from
26d4a2d
to
25d5847
Compare
|
/rebuild |
| static std::shared_ptr<const Utilities::MPI::Partitioner> | ||
| create_coarse_partitioner( | ||
| const DoFHandler<dim> & dof_handler_coarse, | ||
| const dealii::AffineConstraints<Number> &constraint_coarse, |
There was a problem hiding this comment.
Not related to this PR, but it seems that this file uses the term constraint_coarse, whereas most other places would spell this as constraints_coarse (with the plural form).
| const auto constraints = | ||
| constraint_coarse.get_constraint_entries(i); | ||
|
|
||
| if (constraints) |
There was a problem hiding this comment.
Isn't this check doing the same as the one in line 991 above?
There was a problem hiding this comment.
I always had the impression that you need to call is_constrained() before get_constraint_entries(). But after taking a detailed look at:
dealii/include/deal.II/matrix_free/dof_info.templates.h
Lines 143 to 147 in 3cd782f
I came to the realization that it is indeed not need 👍
|
|
||
| if (constraints) | ||
| for (const auto &p : *constraints) | ||
| locally_relevant_dofs_temp.emplace_back(p.first); |
There was a problem hiding this comment.
Shouldn't it be possible to only add those elements that are not yet in locally_active_dofs? In that way, we would later simply append the indices to that previous list, rather than building and sorting a big list again.
peterrum
force-pushed
the
use_src_inplace
branch
from
25d5847
to
13f057e
Compare
first step towards reusing vectors