Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying material IDs on Gmsh imports #13514

Merged
merged 1 commit into from Mar 13, 2022
Merged

Specifying material IDs on Gmsh imports #13514

merged 1 commit into from Mar 13, 2022

Conversation

singimarson
Copy link
Contributor

No description provided.

tjhei
tjhei reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Two suggestions for improvement.

examples/step-49/doc/intro.dox Outdated Show resolved Hide resolved
examples/step-49/doc/intro.dox Outdated Show resolved Hide resolved
@singimarson singimarson force-pushed the workspace branch 2 times, most recently from 6b753c1 to 5361aba Compare March 10, 2022 15:39
@tjhei
Copy link
Member

tjhei commented Mar 11, 2022

The documentation tester fails with

/home/runner/work/dealii/dealii/build/doc/doxygen/tutorial/step-49.h:343: warning: unable to resolve reference to `GlossMaterialID' for \ref command

see
https://github.com/dealii/dealii/runs/5498369075?check_suite_focus=true#step:5:1330

You misspelled "Id" as "ID", I think.

@singimarson
Copy link
Contributor Author

Good catch, just fixed and pushed it!

tjhei
tjhei approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you.

@marcfehling marcfehling merged commit 6fd54f7 into dealii:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Documentation ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@singimarson @tjhei @marcfehling