Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MGLevelObject::n_levels() #13529

Merged
merged 1 commit into from Mar 11, 2022
Merged

Implement MGLevelObject::n_levels() #13529

merged 1 commit into from Mar 11, 2022

Conversation

peterrum
Copy link
Member

No description provided.

@bangerth
Copy link
Member

Looks good to me. I suspect you considered calling the function size() and rejected that idea? (I think that would be inconsistent with the fact that operator[] takes indices that are greater than size()...)

/rebuild

@peterrum
Copy link
Member Author

Looks good to me. I suspect you considered calling the function size() and rejected that idea? (I think that would be inconsistent with the fact that operator[] takes indices that are greater than size()...)

Yes, I find size() a bit confusing in this context. Since we already have min_level and max_level, n_levels seemed like a reasonable choice.

@peterrum peterrum merged commit e45b5e3 into dealii:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

Assignees
No one assigned
Labels
ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterrum @bangerth