Add wrappers for ArborX::Sphere #13565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rombur
force-pushed
the
arborx_sphere
branch
2 times, most recently
from
1feb029
to
3f2c227
Compare
jppelteret
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Just a few very superficial comments from me, otherwise I think this looks good. Thanks @Rombur!
| spheres.reserve(size); | ||
| for (unsigned int i = 0; i < size; ++i) | ||
| { | ||
| spheres.emplace_back(std::make_pair( |
There was a problem hiding this comment.
Do you wish to add here the same comment that you make later, i.e.
// ArborX assumes that the center coordinates and the radius use float and
// the sphere is 3D
?
masterleinad
approved these changes
Mar 25, 2022
|
I have updated the documentation |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArborX supports three different geometrical objects:
Box,Point, andSphere. We already have wrappers forBoxandPoint, this PR adds wrappers forSphere.