Use compressed_constraint_kind in MatrixFree (CPU) #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
force-pushed
the
compressed_constraint_kind_use
branch
from
1768f46
to
274c538
Compare
peterrum
changed the title
kronbichler
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
I assume you verified that the performance or number of instructions does not change significantly with this setup? (The constraint index is too little of a storage cost to be noticeable in terms of memory transfer in an overall matrix-free loop, but of course the new version is much nicer in terms of format.)
I have run the experiments and the cost of cells with hn has hardly changed. |
|
The failing test is spurious, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.