cell_weight: add changelog for bugfix. #13572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
weight-info
branch
from
79217bc
to
39d9a98
Compare
bangerth
approved these changes
Mar 23, 2022
|
@marcfehling I think that was the best solution. It was a bug, you fixed it. Let's live with it :). It takes a few seconds to fix in user code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @blaisb, we should also add to the changelog that callback functions now need to handle the CELL_INVALID status.
Users might encounter problems when they do not handle CELL_INVALID cells in their AMR code. I don't know how to make this backwards compatible, as this really was a bug in our library. What do you think?