Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PIMPL in our muParser implementation. #13577

Merged
merged 4 commits into from
May 11, 2022
Merged

Use PIMPL in our muParser implementation. #13577

merged 4 commits into from
May 11, 2022

Commits on Apr 27, 2022

  1. Remove a header from a previous muParser release. 

    This should not have been ported to the new directory.
    @drwells
    drwells committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    ce974e6 View commit details
    Browse the repository at this point in the history

  2. Switch to using PIMPL with FunctionParser.

    @drwells
    drwells committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a0a98b1 View commit details
    Browse the repository at this point in the history

  3. Namespace our own copy of muParser to prevent downstream conflicts.

    @drwells
    drwells committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    57b023d View commit details
    Browse the repository at this point in the history

  4. Fix linkage with bundled muParser + MSVC. 

    We should always set up the linkage options ourselves (i.e., always use
static linkage) and not let muParser try to set things up for dynamic
linkage in case we forget. This only applies to MSVC.
    @drwells
    drwells committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    75724de View commit details
    Browse the repository at this point in the history