Added support for CGAL library. #13644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouhh, interesting. I will be on the lookout for this :)! |
peterrum
approved these changes
Apr 27, 2022
|
/rebuild |
luca-heltai
force-pushed
the
cgal-support
branch
from
4250ee4
to
80d17b5
Compare
luca-heltai
force-pushed
the
cgal-support
branch
from
51016fc
to
20ee402
Compare
Co-authored-by: Luca Heltai <luca.heltai@gmail.com>
luca-heltai
force-pushed
the
cgal-support
branch
from
20ee402
to
31c5f13
Compare
jppelteret
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
One small suggestion, but other than that this LGTM. Thanks @fdrmrc and @luca-heltai !
|
Maybe you also want to consider amending https://github.com/dealii/dealii/blob/master/doc/readme.html and https://github.com/dealii/dealii/blob/master/doc/users/cmake_dealii.html as well? |
|
btw, the failure in windows is related to uploading artifacts, not to the actual build. |
|
To have at least the docker compiled with CGAL, I've opened |
peterrum
reviewed
Apr 29, 2022
Co-authored-by: Jean-Paul Pelteret <jppelteret@gmail.com>
Merged
jppelteret
reviewed
May 1, 2022
peterrum
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to port to deal.II the support for the CGAL library, that we are using for mesh generation, mesh adaptation, and mesh intersections in github.com/luca-heltai/fsi-suite.
@fdrmrc is the main author, and he'll be pushing many more PR once this is accepted.
I'm not sure if we want to have all of the features we are currently supporting before the release, but I think it would be nice to have this in 9.4, so that people with some CGAL experience could already benefit from it.