First try at detecting CGAL more robustly. #13669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have worked, at least for the tester.
|
drwells
reviewed
May 4, 2022
| IF(CGAL_FOUND) | ||
| GET_TARGET_PROPERTY(CGAL_LIBRARIES CGAL::CGAL INTERFACE_LINK_LIBRARIES) | ||
| # Make sure we dont' pass Boost::Boost over to deal.II. | ||
| LIST(FILTER CGAL_LIBRARIES EXCLUDE REGEX "::") |
There was a problem hiding this comment.
This might not work with all configurations since I think this will also filter out Eigen3. I think GMP and MPFR are okay - those are not using CMake namespaces on my machine.
drwells
approved these changes
May 4, 2022
tamiko
approved these changes
May 4, 2022
|
Let's get this in as is and let's fix the underlying issue in a separate pull request. |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #13668.
This is still not perfect. I'm waiting for feedback from @tamiko.
However, it should now work on our CI testers, and it works on all machines I have. I'm not sure if boost libraries are included correctly, and there may be issues with some of them, but so far this is ok, since we are not yet using anything fancy from CGAL that requires boost stuff we don't already include.
Merging this makes sure that at least we check if the compilation of the library with CGAL support succeeds.