CGAL C3T3 to deal.II Triangulation. #13735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
May 16, 2022
luca-heltai
force-pushed
the
cgal-support-c3t3
branch
3 times, most recently
from
edc2f96
to
3262c32
Compare
drwells
requested changes
May 17, 2022
include/deal.II/cgal/triangulation.h
Outdated
| cgal_cell != cgal_triangulation.cells_in_complex_end(); | ||
| ++cgal_cell) | ||
| { | ||
| CellData<3> cell(4); |
There was a problem hiding this comment.
Could we use ReferenceCell::n_vertices() here and below? Even if this only works with tets I would prefer not to hardcode these values.
luca-heltai
force-pushed
the
cgal-support-c3t3
branch
from
3262c32
to
e41f48b
Compare
drwells
approved these changes
May 17, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
CGAL C3T3 to deal.II Triangulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added utility to transform c3t3 to deal.II Triangulation. Feature indices of the CGAL Triangulation are stored in manifold ids.