Remove std::abs() from the tet volume calculation. #13765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
bangerth
reviewed
May 20, 2022
drwells
force-pushed
the
signed-tet-volume
branch
from
5b3343e
to
a68e537
Compare
bangerth
approved these changes
May 21, 2022
drwells
force-pushed
the
signed-tet-volume
branch
from
a68e537
to
15f6645
Compare
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Remove std::abs() from the tet volume calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13584.
After this is in I will examine our calls to
invert_cells_with_negative_measure()and other relevant grid fixup functions - we can call some of these now for simplex meshes but some (likeconsistently_order_cells()) still only work with hypercubes.