Create a Triangulation<3> from a Triangulation<2,3> #13767

fdrmrc · 2022-05-20T22:32:12Z

This creates a Triangulation<3> out of a Triangulation<2,3>, filling the latter with tetrahedrons. Named parameters can be used to control the size and the quality of the final mesh.
I put this into GridTools, but I'm happy to move this somewhere else if you think it's not the right namespace/place.

The .cc test is just filling an hypersphere, but one could use this after boolean operations (#13717) , giving the capability of meshing things like the following, where the union of two spheres is computed and meshed inside

luca-heltai · 2022-05-22T15:53:22Z

I think this should go in grid_geneerator.h, next to its "inverse", i.e., the function that extracts a boundary mesh from a Triangulation.

luca-heltai

Besides moving it to grid_generator.h, I think the documentation should be filled with the information about the additional parameters.

include/deal.II/grid/grid_tools.h

tests/cgal/cgal_triangulation_07.cc

peterrum

Very nice!

peterrum · 2022-05-22T21:06:29Z

include/deal.II/grid/grid_tools.h

+  void
+  surface_mesh_to_volumetric_mesh(const Triangulation<2, 3> &surface_tria,
+                                  Triangulation<3> &         vol_tria,
+                                  Args... cgal_args);


Personally, I would prefer to introduce an AdditionalData.

Can we move #ifdef DEAL_II_WITH_CGAL within the function and assert it there?

peterrum · 2022-05-22T21:08:02Z

include/deal.II/grid/grid_tools.h

+#ifdef DEAL_II_WITH_CGAL
+  template <typename... Args>
+  void
+  surface_mesh_to_volumetric_mesh(const Triangulation<2, 3> &surface_tria,
+                                  Triangulation<3> &         vol_tria,
+                                  Args... cgal_args);
+#endif


Why is this here? Isn't this the same as above?

fdrmrc · 2022-05-22T21:12:05Z

@peterrum I pushed right after you wrote the review!

peterrum · 2022-05-22T21:12:09Z

One question: the original surface mesh determines the cells of the volume mesh on the surface or are the cells unrelated?

fdrmrc · 2022-05-22T21:29:34Z

One question: the original surface mesh determines the cells of the volume mesh on the surface or are the cells unrelated?

They're currently unrelated. The use case I had in mind is like the one in the test: one just starts with a deal.II tria describing the surface and fills it. Another use case is the one with boolean operations I wrote in first message. However, it shouldn't be a problem to record the topological information about the first deal.II surface tria and use it to create the volumetric one.

bangerth · 2022-06-02T20:48:52Z

include/deal.II/grid/grid_generator.h

+  template <typename... Args>
+  void
+  surface_mesh_to_volumetric_mesh(const Triangulation<2, 3> &surface_tria,
+                                  Triangulation<3> &         vol_tria,
+                                  Args... cgal_args);


I will object to this on the same grounds as for the other patch.

Sure. As soon as the other patch is okay, I can update this!

fdrmrc · 2022-06-06T14:59:22Z

So done, this should be good to go now.
Since the function is not templated anymore, I've moved it inside grid_generator.cc.

Also, I took the liberty to move the two utility functions that convert points back and forth from deal.II to CGAL in a separate header, fixing some issues with headers inclusions I hadn't noticed before.

luca-heltai

Minor change required: add an implementation stub that throws ExcNotImplemented if cgal is not found.

luca-heltai · 2022-06-06T17:13:49Z

source/grid/grid_generator.cc

+    CGALWrappers::cgal_triangulation_to_dealii_triangulation(cgal_triangulation,
+                                                             vol_tria);
+  }
+#  endif


Can you add a default implementation that throws an error saying that the function needs CGAL to be installed?

kronbichler

Looks good, apart from some adaptations to the comments.

kronbichler · 2022-06-07T07:45:31Z

include/deal.II/grid/grid_generator.h

+
+  /**
+   * Create a deal.II Triangulation<3> out of a deal.II Triangulation<2,3>
+   * by filling it with tetrahedrons.


Suggested change

* by filling it with tetrahedrons.

* by filling it with tetrahedra.

kronbichler · 2022-06-07T07:46:07Z

include/deal.II/grid/grid_generator.h

+   * The optional variable arguments @p cgal_args can be used to pass additional
+   * arguments to the CGAL::Mesh_criteria_3 class (see
+   * https://doc.cgal.org/latest/Mesh_3/index.html) for more information.


Can you please adapt this and the text below, as we have now introduced AdditionalData.

fdrmrc · 2022-06-07T17:47:11Z

I'm addressing Luca's comment, please don't merge

fdrmrc · 2022-06-08T09:43:58Z

I rebased this PR onto the smaller ones #13929 and #13932, so that here there's effectively only the implementation of surface_tria_to_volumetric().

~~So only d1e69d2 is the relevant commit~~

fdrmrc · 2022-06-10T17:14:46Z

Rebased on top of master.

fdrmrc · 2022-06-11T10:21:48Z

The implementation of the present function has been moved in grid_generator_cgal.cc, following #13954

…_volumetric Create a Triangulation<3> from a Triangulation<2,3>

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch from 0ed2dc1 to 8d4108a Compare May 20, 2022 22:44

luca-heltai added ready for review External libraries ready to test labels May 22, 2022

luca-heltai added this to In progress in CGAL Support via automation May 22, 2022

luca-heltai requested changes May 22, 2022

View reviewed changes

include/deal.II/grid/grid_tools.h Outdated Show resolved Hide resolved

tests/cgal/cgal_triangulation_07.cc Outdated Show resolved Hide resolved

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch 3 times, most recently from 8d4108a to 4b1e1f4 Compare May 22, 2022 21:09

peterrum reviewed May 22, 2022

View reviewed changes

luca-heltai changed the title ~~Convert Triangulation<2,3> to Triangulation<3>~~ Create a Triangulation<3> from a Triangulation<2,3> May 25, 2022

fdrmrc mentioned this pull request May 26, 2022

Cgal dealii tria from implicit function #13743

Merged

kronbichler mentioned this pull request May 27, 2022

Variadic template parameter for CGAL Mesh criteria #13753

Merged

luca-heltai added this to the Release 9.4 milestone May 27, 2022

bangerth reviewed Jun 2, 2022

View reviewed changes

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch 2 times, most recently from ab71efb to b5418bc Compare June 6, 2022 14:48

luca-heltai approved these changes Jun 6, 2022

View reviewed changes

kronbichler approved these changes Jun 7, 2022

View reviewed changes

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch 4 times, most recently from 1df12e7 to be72338 Compare June 7, 2022 16:49

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch from be72338 to 1371aac Compare June 7, 2022 19:39

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch 3 times, most recently from bb17e55 to 8141e31 Compare June 8, 2022 09:42

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch 5 times, most recently from d1e69d2 to 2337fe4 Compare June 10, 2022 17:12

kronbichler approved these changes Jun 10, 2022

View reviewed changes

Surface deal.II tria to volumetric deal.II tria

8d243fd

fdrmrc force-pushed the cgal-surface_tria_to_volumetric branch from 2337fe4 to 8d243fd Compare June 11, 2022 09:46

kronbichler approved these changes Jun 11, 2022

View reviewed changes

kronbichler merged commit 990806d into dealii:master Jun 11, 2022

CGAL Support automation moved this from In progress to Done Jun 11, 2022

mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022

Merge pull request dealii#13767 from luca-heltai/cgal-surface_tria_to…

6a8b400

…_volumetric Create a Triangulation<3> from a Triangulation<2,3>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a Triangulation<3> from a Triangulation<2,3> #13767

Create a Triangulation<3> from a Triangulation<2,3> #13767

fdrmrc commented May 20, 2022 •

edited

luca-heltai commented May 22, 2022

luca-heltai left a comment

peterrum left a comment

peterrum May 22, 2022

peterrum May 22, 2022

peterrum May 22, 2022

fdrmrc commented May 22, 2022

peterrum commented May 22, 2022

fdrmrc commented May 22, 2022 •

edited

bangerth Jun 2, 2022

fdrmrc Jun 3, 2022

fdrmrc commented Jun 6, 2022

luca-heltai left a comment

luca-heltai Jun 6, 2022

kronbichler left a comment

kronbichler Jun 7, 2022

kronbichler Jun 7, 2022

fdrmrc commented Jun 7, 2022

fdrmrc commented Jun 8, 2022 •

edited

fdrmrc commented Jun 10, 2022

fdrmrc commented Jun 11, 2022

	* by filling it with tetrahedrons.
	* by filling it with tetrahedra.

Create a Triangulation<3> from a Triangulation<2,3> #13767

Create a Triangulation<3> from a Triangulation<2,3> #13767

Conversation

fdrmrc commented May 20, 2022 • edited

luca-heltai commented May 22, 2022

luca-heltai left a comment

Choose a reason for hiding this comment

peterrum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdrmrc commented May 22, 2022

peterrum commented May 22, 2022

fdrmrc commented May 22, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdrmrc commented Jun 6, 2022

luca-heltai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kronbichler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fdrmrc commented Jun 7, 2022

fdrmrc commented Jun 8, 2022 • edited

fdrmrc commented Jun 10, 2022

fdrmrc commented Jun 11, 2022

fdrmrc commented May 20, 2022 •

edited

fdrmrc commented May 22, 2022 •

edited

fdrmrc commented Jun 8, 2022 •

edited