CGAL: Add remesh_surface utility #13771
Conversation
|
/rebuild |
fdrmrc
force-pushed
the
cgal-Surface_remeshing
branch
2 times, most recently
from
a9a9e28
to
9107a93
Compare
|
We are at the point where we need to focus on fixing bugs and not adding new features for 9.4. Can we push this back to 9.5? |
|
I think this one is pretty safe, as the body of this function is taken verbatim from a CGAL example program. But of course I am totally fine with postponing this if you think it's better @drwells |
fdrmrc
force-pushed
the
cgal-Surface_remeshing
branch
from
9107a93
to
ec6c80a
Compare
|
@fdrmrc, can you replace the variadic argument also in this PR? |
fdrmrc
force-pushed
the
cgal-Surface_remeshing
branch
5 times, most recently
from
fd8afd4
to
e594127
Compare
include/deal.II/cgal/triangulation.h
Outdated
| template <int dim> | ||
| void | ||
| implicit_function(Triangulation<dim, 3> & tria, | ||
| const Function<3> & implicit_function, | ||
| const CGALWrappers::AdditionalData<dim> &data = | ||
| CGALWrappers::AdditionalData<dim>{}, | ||
| const Point<3> &interior_point = Point<3>(), | ||
| const double & outer_ball_radius = 1.0); |
There was a problem hiding this comment.
How is this function related to the intent of this PR? I also cannot find the definition of the function, so I assume this is spurious? I guess we should aim to calm down in adding new features from CGAL at this stage of the release cycle.
There was a problem hiding this comment.
I'm really sorry, I lost it while rebasing. Haste makes waste. Now it's fixed.
According to CGALSupport this is the last CGAL-related PR for 9.4, but I'm fine with postponing it, as the last thing I want is to introduce bugs.
fdrmrc
force-pushed
the
cgal-Surface_remeshing
branch
from
e594127
to
becbd44
Compare
fdrmrc
force-pushed
the
cgal-Surface_remeshing
branch
from
becbd44
to
a35ae8e
Compare
|
@luca-heltai @kronbichler I need a call on this pull request regarding the release 🙂 |
CGAL: Add remesh_surface utility
As the name says, this utility allows to remesh CGAL surfaces. The main purpose of this is to improve the quality of grids coming from boolean operations. As an example, one can start from doc/doxygen/images/boolean_union_hyper_spheres.png and get doc/doxygen/images/boolean_union_hyper_spheres_remeshed.png