Refactor function parser #13773
Merged
Refactor function parser #13773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
force-pushed
the
refactor-function-parser
branch
2 times, most recently
from
e53a933
to
d10f56d
Compare
drwells
force-pushed
the
refactor-function-parser
branch
from
d10f56d
to
2c037e7
Compare
Comment on lines
+161
to
+200
| return {// functions predefined by muparser | ||
| "sin", | ||
| "cos", | ||
| "tan", | ||
| "asin", | ||
| "acos", | ||
| "atan", | ||
| "sinh", | ||
| "cosh", | ||
| "tanh", | ||
| "asinh", | ||
| "acosh", | ||
| "atanh", | ||
| "atan2", | ||
| "log2", | ||
| "log10", | ||
| "log", | ||
| "ln", | ||
| "exp", | ||
| "sqrt", | ||
| "sign", | ||
| "rint", | ||
| "abs", | ||
| "min", | ||
| "max", | ||
| "sum", | ||
| "avg", | ||
| // functions we define ourselves above | ||
| "if", | ||
| "int", | ||
| "ceil", | ||
| "cot", | ||
| "csc", | ||
| "floor", | ||
| "sec", | ||
| "pow", | ||
| "erf", | ||
| "erfc", | ||
| "rand", | ||
| "rand_seed"}; |
There was a problem hiding this comment.
Should this list be static and the function return a const & to it?
There was a problem hiding this comment.
We could do that, but we only call this when we set up the muParser objects so its not going to make a measurable performance difference. I would prefer not to add extra static objects unless we need to.
|
ping |
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #13745 - we can avoid duplicating a lot of code by adding another base class. We need to use a separate base class (instead of just functions) so that we can use the PIMPL idiom.