Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massively lower some IDA solver tolerances. #13787

Merged
merged 1 commit into from May 26, 2022

Conversation

drwells
Copy link
Member

@drwells drwells commented May 23, 2022

ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense since that's the provided solver tolerance. We can get consistent results by making it a few orders of magnitude lower.

@drwells
Copy link
Member Author

drwells commented May 23, 2022

Part of #13703.

@kronbichler
Copy link
Member

On the serial CI, the first test still seems to fail:

sundials/ida_01.debug: DIFF failed. ------ First 20 lines of numdiff output:
----------------
##2       #:2   <== 0.198666
##2       #:2   ==> 0.198669
@ Absolute error = 3.0000000000e-6, Relative error = 1.5100721815e-5
##2       #:3   <== 0.98005
##2       #:3   ==> 0.980067
@ Absolute error = 1.7000000000e-5, Relative error = 1.7346053773e-5
##2       #:4   <== 0.980056
##2       #:4   ==> 0.980067
@ Absolute error = 1.1000000000e-5, Relative error = 1.1223848433e-5
##2       #:5   <== -0.198643
##2       #:5   ==> -0.198669
@ Absolute error = 2.6000000000e-5, Relative error = 1.3088807559e-4
----------------
##3       #:2   <== 0.389414
##3       #:2   ==> 0.389418
@ Absolute error = 4.0000000000e-6, Relative error = 1.0271844361e-5
##3       #:3   <== 0.921051
##3       #:3   ==> 0.921061
@ Absolute error = 1.0000000000e-5, Relative error = 1.0857162090e-5

@drwells drwells force-pushed the sundials-ida-tolerance branch 2 times, most recently from 2df761b to 311287a Compare May 23, 2022 20:52
ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense
since that's the provided solver tolerance. We can get consistent results by
making it a few orders of magnitude lower.
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense since that's the provided solver tolerance. We can get consistent results by making it a few orders of magnitude lower.

You meant ida_01, right?

This change shouldn't increase runtime significantly, so to me this is fine.

@drwells
Copy link
Member Author

drwells commented May 24, 2022

Both, actually, and they both use the same prm file.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok with me. Do I understand @kronbichler 's comment as an objection?

@masterleinad masterleinad merged commit b34a5e8 into dealii:master May 26, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants