New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massively lower some IDA solver tolerances. #13787
Conversation
Part of #13703. |
On the serial CI, the first test still seems to fail:
|
2df761b
to
311287a
Compare
ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense since that's the provided solver tolerance. We can get consistent results by making it a few orders of magnitude lower.
311287a
to
551f855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense since that's the provided solver tolerance. We can get consistent results by making it a few orders of magnitude lower.
You meant ida_01, right?
This change shouldn't increase runtime significantly, so to me this is fine.
Both, actually, and they both use the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok with me. Do I understand @kronbichler 's comment as an objection?
ida_02 presently fails with a numdiff difference of about 1e-6: this makes sense since that's the provided solver tolerance. We can get consistent results by making it a few orders of magnitude lower.