Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreconditionChebyshev: Implement power iteration for eigenvalue estimate #13792

Merged
merged 3 commits into from May 23, 2022

Conversation

kronbichler
Copy link
Member

This implements a different option for the eigenvalue estimation in PreconditionChebyshev. In general, the Lanczos algorithm that we use as a default results in much more accurate predictions for the same number of iterations, but the new option might be useful for some non-symmetric matrices.

Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

On a branch, I have extracted the logic here to be able to use it also to determine reasonable relaxation parameters for PreconditionRelaxation (block-Jacobi, block-Gauss-Seidel). The additions here will be useful there as well!

@kronbichler
Copy link
Member Author

Note that I had a small bug in my code (I did not copy the eigenvalue estimation algorithm in the copy assignment operator of AdditionalData). Now things work correctly and the failing test from the serial CI should also pass again.

@drwells drwells merged commit 7255178 into dealii:master May 23, 2022
@kronbichler kronbichler deleted the chebyshev_power_iteration branch September 5, 2022 12:12
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
…ation

PreconditionChebyshev: Implement power iteration for eigenvalue estimate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants