Require SUNDIALS 5.4 or later. #13793
Conversation
|
The CI Tester is set up with 3.1: we will either need to update it in time for the release or partially roll this back. |
There was a problem hiding this comment.
Sundials 5.4 was released 2020-09-23.
Mmh, I don't want to object to this patch. It discards subdials versions that are older than one and a half years, but I don't see sundials as critical to deal.II as for example p4est, petsc and trilinos.
So I'm in favor of this change. What do the others think?
|
After merging #13786, you need to rebase. Sorry about that. |
|
We should definitely talk about this at the developer meeting tomorrow - I'll rebase once we reach a consensus. |
|
No one explicitly disagreed with removing support for these older versions. We still need to update the documentation and fix tests, so I'd appreciate if we could get this in quickly. |
|
If you think this is a bad idea let me know :) |
|
@tamiko do you want to have the last call on this one? |
|
My preference would have been to preserve backward compatibility, but I recognize that that is something that requires time and effort none of us have. So this is ok with me. I'll let @tamiko make the last call. |
|
We agreed to merge this on the call just now. |
Require SUNDIALS 5.4 or later.
We cannot presently compile
masterwith SUNDIALS 4.0 or 4.1 and backporting our new features to support this older release is going to be a major difficulty as 4.0, 4.1, 5.0-5.4 all add significant features that we might want to use (nevermind supporting version 3).Hence - lets require 5.4 or newer (the changes on the 5.x branch after that point are minor). With this change I can cleanly compile the library with both 5.4 and 6.2. The new (22.04) Ubuntu LTS ships 5.8 so we cover that (but 20.04 ships 3.1)