Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary MPI barriers #13812

Merged
merged 1 commit into from May 25, 2022
Merged

Remove unnecessary MPI barriers #13812

merged 1 commit into from May 25, 2022

Conversation

kronbichler
Copy link
Member

We nowadays have a barrier in the actual exchange facilities,

dealii/include/deal.II/grid/grid_tools.h

Lines 4399 to 4403 in 425bf33

// Before sending & receiving, make sure we protect this section with
// a mutex:
static Utilities::MPI::CollectiveMutex mutex;
Utilities::MPI::CollectiveMutex::ScopedLock lock(
mutex, tria->get_communicator());

Hence we do not need to introduce manual barriers around the communicate_dof_indices_on_marked_cells functions of the DoF handler setup.

@drwells drwells merged commit 26e0506 into dealii:master May 25, 2022
@kronbichler kronbichler deleted the simplify_code branch September 5, 2022 12:10
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
@drwells
Merge pull request dealii#13812 from kronbichler/simplify_code
c64f0d1 
Remove unnecessary MPI barriers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrum peterrum peterrum approved these changes

Assignees
No one assigned
Labels
Parallel distributed ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kronbichler @peterrum @drwells