CMake: Skip expensive boost test #13827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been finally fixed upstream sometime in late 2018 [1], and this runtime check is very expensive. Let us skip it for a safe, good version. I have chosen 1.74 semi randomly because it has been released in 2020 and is the boost version found in Debian 11. [1] boostorg/serialization#79 (comment)
|
Incidentally, this fixes some issue I am seing with the code for this test and clang-14... |
kronbichler
approved these changes
May 25, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
CMake: Skip expensive boost test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been finally fixed upstream sometime in late 2018 [1], and this
runtime check is very expensive. Let us skip it for a safe, good
version. I have chosen 1.74 semi randomly because it has been released
in 2020 and is the boost version found in Debian 11.
[1] boostorg/serialization#79 (comment)