Deprecate GridTools::CellDataTransferBuffer #13833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
May 26, 2022
|
Thanks! |
bangerth
approved these changes
May 26, 2022
|
You'll have to get it past the testers though. I don't know why it's complaining about the use of the deprecated class :-( |
|
@bangerth that is annoying - let me try to move the definitions of the functions inline, which hopefully works fine with all compilers (even though this is not our usual style, but against other alternatives that come to mind I think that would be the least intrusive one for a deprecated class). |
kronbichler
force-pushed
the
deprecate_cell_data_transfer_buffer
branch
from
d949332
to
f71c1d3
Compare
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
…transfer_buffer Deprecate GridTools::CellDataTransferBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #13817, where we agreed to deprecate this class first. It can be removed in a future release.