Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog for the new CutFEM functionality in NonMatching. #13847

Merged
merged 1 commit into from May 30, 2022

Conversation

simonsticko
Copy link
Contributor

No description provided.

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please break the lines at around 80 characters? Furthermore, I have some suggestions for removing some hyphens in my comment below.

FEImmersedSurfaceValues is a FEValues-like class for evaluating real space values based on an ImmersedSurfaceQuadrature, i.e., for integrating over the zero contour in a cell.
</li>
<li>
NonMatching::FEValues simplifies assembling by creating dealii::FEValues- and FEImmersedSurfaceValues-objects initialized with the 3 different immersed quadratures of a cell. Analogously, NonMatching::FEInterfaceValues creates dealii::FEInterfaceValues-objects initialized with immersed quadrature rules over a face.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NonMatching::FEValues simplifies assembling by creating dealii::FEValues- and FEImmersedSurfaceValues-objects initialized with the 3 different immersed quadratures of a cell. Analogously, NonMatching::FEInterfaceValues creates dealii::FEInterfaceValues-objects initialized with immersed quadrature rules over a face.
NonMatching::FEValues simplifies assembling by creating dealii::FEValues and
FEImmersedSurfaceValues objects initialized with the 3 different immersed
quadratures of a cell. Analogously, NonMatching::FEInterfaceValues creates
dealii::FEInterfaceValues objects initialized with immersed quadrature rules over a face.

@kronbichler kronbichler merged commit 31efc61 into dealii:master May 30, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Add a changelog for the new CutFEM functionality in NonMatching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants