Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LargeCount MPI_write_at and MPI_read_at functions #13851

Merged
merged 1 commit into from May 30, 2022

Conversation

pengfej
Copy link
Contributor

@pengfej pengfej commented May 29, 2022

No description provided.

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

source/distributed/tria_base.cc Outdated Show resolved Hide resolved
sizes_fixed_cumulative.size(),
MPI_UNSIGNED,
MPI_STATUS_IGNORE);
ierr = Utilities::MPI::LargeCount::MPI_File_write_at_c(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not strictly necessary, as the header will not exceed 2GB, but this is what @bangerth suggested in his review of the other PR. So let's do the change here as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated!

@tjhei tjhei changed the title Updating write at and read at functions. Use LargeCount MPI_write_at and MPI_read_at functions May 29, 2022
forgot to include the big mpi file

removing empty line
@pengfej pengfej force-pushed the updating_read_write_at_functions branch from 4a7d7b7 to 7ade5e9 Compare May 29, 2022 19:48
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tjhei
Copy link
Member

tjhei commented May 30, 2022

Let me run the large tests to be sure...

@pengfej
Copy link
Contributor Author

pengfej commented May 30, 2022

Let me run the large tests to be sure...

Sounds good! Thanks a lot!

sizes_fixed_cumulative.size(),
MPI_UNSIGNED,
MPI_STATUS_IGNORE);
ierr = Utilities::MPI::LargeCount::MPI_File_write_at_c(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated!

@bangerth bangerth merged commit ae589d5 into dealii:master May 30, 2022
@bangerth
Copy link
Member

Thanks, @tjhei !

This is the kind of stuff that is often difficult to test because we don't check these things easily within a single program. Out of curiosity, do you know whether these calls are checked in any of our existing tests?

@tjhei
Copy link
Member

tjhei commented May 30, 2022

Out of curiosity, do you know whether these calls are checked in any of our existing tests?

The functions Utilities::MPI::LargeCount::* are tested to work with various MPI libraries here: https://github.com/tjhei/BigMPICompat#test-results
The code in question here is used for checkpointing and we have tests/distributed_grids/checkpointing_0*.cc and they have a bool flag that one has to manually change to check the large file issues. This is what I meant by "Let me run the large tests to be sure...".

mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
…unctions

Use LargeCount MPI_write_at and MPI_read_at functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants