New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LargeCount MPI_write_at and MPI_read_at functions #13851
Use LargeCount MPI_write_at and MPI_read_at functions #13851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
sizes_fixed_cumulative.size(), | ||
MPI_UNSIGNED, | ||
MPI_STATUS_IGNORE); | ||
ierr = Utilities::MPI::LargeCount::MPI_File_write_at_c( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly necessary, as the header will not exceed 2GB, but this is what @bangerth suggested in his review of the other PR. So let's do the change here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciated!
forgot to include the big mpi file removing empty line
4a7d7b7
to
7ade5e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Let me run the large tests to be sure... |
Sounds good! Thanks a lot! |
sizes_fixed_cumulative.size(), | ||
MPI_UNSIGNED, | ||
MPI_STATUS_IGNORE); | ||
ierr = Utilities::MPI::LargeCount::MPI_File_write_at_c( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciated!
Thanks, @tjhei ! This is the kind of stuff that is often difficult to test because we don't check these things easily within a single program. Out of curiosity, do you know whether these calls are checked in any of our existing tests? |
The functions Utilities::MPI::LargeCount::* are tested to work with various MPI libraries here: https://github.com/tjhei/BigMPICompat#test-results |
…unctions Use LargeCount MPI_write_at and MPI_read_at functions
No description provided.