Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for global coarsening: Must allow invalid proc id #13858

Merged
merged 1 commit into from May 30, 2022
Merged

Fix bug for global coarsening: Must allow invalid proc id #13858

merged 1 commit into from May 30, 2022

Conversation

kronbichler
Copy link
Member

This fixes a bug that appeared due to #13791: We can only fill the full range with the data of the first process adding indices when we know that the full index range will be covered, otherwise we need to still run the old code. This fixes the four tests

multigrid-global-coarsening/block_01.mpirun=1.release
multigrid-global-coarsening/interpolate_01.mpirun=1.release
multigrid-global-coarsening/interpolate_01.mpirun=4.release
multigrid-global-coarsening/multigrid_a_01.mpirun=1.release

This bug was hard to find because I was looking somewhere else first in terms of the consensus algorithms, missing the actual cause.

@kronbichler kronbichler added this to the Release 9.4 milestone May 30, 2022
@kronbichler
Copy link
Member Author

Related to #13703.

@drwells drwells merged commit 3a00cfa into dealii:master May 30, 2022
@kronbichler kronbichler deleted the fix_bug_global_coarsening branch September 5, 2022 12:10
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
@drwells
Merge pull request dealii#13858 from kronbichler/fix_bug_global_coars…
1f0f308 
…ening

Fix bug for global coarsening: Must allow invalid proc id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

Assignees
No one assigned
Labels
Multigrid Parallel distributed ready to test Reviewed and ready to merge
Projects
None yet
Milestone
Release 9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kronbichler @tjhei @drwells