Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lex_faces from matrix-free kernels #13909

Merged
merged 1 commit into from Jun 10, 2022

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Jun 5, 2022

With hyperdeal/hyperdeal#103, we could remove this option.

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think this is a pretty safe change, since we have hundreds of tests exercising the remaining code path. But it is late in the release cycle, so I wonder if you would like to still have it in the 9.4 release.

@kronbichler
Copy link
Member

/build

@kronbichler
Copy link
Member

You will also need to check the simplex/step-12c test as shown by the CI.

@kronbichler kronbichler merged commit 3abca26 into dealii:master Jun 10, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Remove lex_faces from matrix-free kernels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants