Fix orientation issue with hex cells. #13912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-heltai
force-pushed
the
cgal-fix-orientation-hex
branch
2 times, most recently
from
afdc392
to
fe69eb1
Compare
|
/rebuild |
kronbichler
approved these changes
Jun 6, 2022
source/cgal/surface_mesh.cc
Outdated
| // In order for CGAL to be able to produce the right orientation, we need | ||
| // to revers the order of the vertices for faces with even index. | ||
| // to revers the order of the vertices for faces with even index. However, |
There was a problem hiding this comment.
Suggested change
| // to revers the order of the vertices for faces with even index. However, | |
| // to reverse the order of the vertices for faces with even index. However, |
fdrmrc
force-pushed
the
cgal-fix-orientation-hex
branch
from
fe69eb1
to
f0926e0
Compare
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
…-hex Fix orientation issue with hex cells.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cells in 3d do not have standard face orientation in hexes. Simplest case: hyper ball.
This change makes sure that we create CGAL surface meshes with correct face orientation when transforming single cells into surface meshes.