MatrixFree: Simplify some code in initialization of DoF indices #13951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Jun 28, 2022
| @@ -1291,10 +1288,12 @@ namespace internal | |||
|
|
|||
| for (unsigned int no = 0; no < n_dof_handlers; ++no) | |||
| { | |||
| const DoFHandler<dim> *dofh = &*dof_handler[no]; | |||
There was a problem hiding this comment.
Suggested change
| const DoFHandler<dim> *dofh = &*dof_handler[no]; | |
| const auto dofh = dof_handler[no]; |
?
There was a problem hiding this comment.
I made a change: I still spell out DoFHandler<dim>, but I got rid of the weird pointer dereferencing (&*) by using a reference instead.
kronbichler
force-pushed
the
simplify_some_code
branch
from
ab657cc
to
96431ec
Compare
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
MatrixFree: Simplify some code in initialization of DoF indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some code that exists in both an
ifandelsebranch out of the condition. Furthermore, to detect the constrained DoFs kept in anAffineConstraintswe can simply go through the lines of the object, rather than checking all DoFs.