Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HDF5 output with one rank having no cells #13962

Merged
merged 2 commits into from Jul 6, 2022

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jun 13, 2022

This is the first part of the fix for #13404 to fix the hdf5 output itself. The xdmf output will have to wait for a separate PR.

It turns out that fixing this was a lot harder than expected as information is needed on all MPI ranks that is just not available (number of cells, type of cells, etc.). It seems easier to create a subcoommunicator.

part of #13404

@tjhei
Copy link
Member Author

tjhei commented Jul 6, 2022

Ping.

Copy link
Member

@tamiko tamiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -0,0 +1,91 @@
// ---------------------------------------------------------------------
//
// Copyright (C) 2017 - 2021 by the deal.II authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year.

// Verify that there are indeed patches to be written out. most of the times,
// people just forget to call build_patches when there are no patches, so a
// warning is in order. That said, the assertion is disabled if we run with
// more than one MPI rank,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary line break

@tamiko tamiko merged commit 204c5e6 into dealii:master Jul 6, 2022
@tjhei tjhei deleted the hdf_empty branch July 6, 2022 17:25
tjhei added a commit to tjhei/dealii that referenced this pull request Sep 2, 2022
followup to dealii#13962 (hdf writing with no cells on rank 0)

fixes dealii#13404
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Support HDF5 output with one rank having no cells
tjhei added a commit to tjhei/dealii that referenced this pull request Sep 18, 2022
followup to dealii#13962 (hdf writing with no cells on rank 0)

fixes dealii#13404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants