New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HDF5 output with one rank having no cells #13962
Conversation
Ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -0,0 +1,91 @@ | |||
// --------------------------------------------------------------------- | |||
// | |||
// Copyright (C) 2017 - 2021 by the deal.II authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright year.
// Verify that there are indeed patches to be written out. most of the times, | ||
// people just forget to call build_patches when there are no patches, so a | ||
// warning is in order. That said, the assertion is disabled if we run with | ||
// more than one MPI rank, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary line break
followup to dealii#13962 (hdf writing with no cells on rank 0) fixes dealii#13404
Support HDF5 output with one rank having no cells
followup to dealii#13962 (hdf writing with no cells on rank 0) fixes dealii#13404
This is the first part of the fix for #13404 to fix the hdf5 output itself. The xdmf output will have to wait for a separate PR.
It turns out that fixing this was a lot harder than expected as information is needed on all MPI ranks that is just not available (number of cells, type of cells, etc.). It seems easier to create a subcoommunicator.
part of #13404