Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: use full compiler/linker flags for trilinos sanity checks #13969

Merged
merged 1 commit into from Jun 13, 2022

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 13, 2022

No description provided.

@tamiko tamiko added this to the Release 9.4 milestone Jun 13, 2022
@drwells
Copy link
Member

drwells commented Jun 13, 2022

/rebuild

@drwells
Copy link
Member

drwells commented Jun 13, 2022

We definitely add these flags if we are using Kokkos with OpenMP. Is it possible to get in a situation where we do not have kokkos but we do have tpetra with openmp?

@Rombur
Copy link
Member

Rombur commented Jun 13, 2022

Is it possible to get in a situation where we do not have kokkos but we do have tpetra with openmp?

No Tpetra is built on top of Kokkos. You cannot have Tpetra without Kokkos

@tamiko
Copy link
Member Author

tamiko commented Jun 13, 2022

@drwells We also set up openmp in check_01_cpu_features.cmake - so we should be good. :-)

@tamiko tamiko merged commit d00b750 into dealii:master Jun 13, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
CMake: use full compiler/linker flags for trilinos sanity checks
@tamiko tamiko deleted the fix_trilinos_checks branch November 30, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants