Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test work without PETSc #13983

Closed
wants to merge 1 commit into from
Closed

Make test work without PETSc #13983

wants to merge 1 commit into from

Conversation

kronbichler
Copy link
Member

@kronbichler kronbichler added this to the Release 9.4 milestone Jun 15, 2022
@drwells
Copy link
Member

drwells commented Jun 15, 2022

Should this only be enabled when we have real-valued PetscScalar?

@kronbichler
Copy link
Member Author

I recently tried to extend it to work with complex PETSc, see #13961, I am still waiting for the tester to get to the point where we can verify that the attempt of #13691 was successful.

@kronbichler
Copy link
Member Author

I agree with @drwells, this test is too complicated to fix with complex PETSc. It turned out that my fix was not enough, and when I tried locally I realized I would have had to change at least five or six additional places, which is not worth it.

@kronbichler kronbichler mentioned this pull request Jun 16, 2022
Merged
@kronbichler kronbichler deleted the fix_petsc_in_test branch September 5, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwells drwells drwells approved these changes

Assignees
No one assigned
Labels
ready to test Tests
Projects
None yet
Milestone
Release 9.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kronbichler @drwells