MatrixFree: improve assert #14005
Merged
MatrixFree: improve assert #14005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Jun 17, 2022
source/matrix_free/task_info.cc
Outdated
| cell_vectorization_categories[cell] == | ||
| cell_vectorization_categories[n_active_cells], | ||
| ExcMessage( | ||
| "Currently, all ghost cells need to have the same category. " |
There was a problem hiding this comment.
Can you add something like
Suggested change
| "Currently, all ghost cells need to have the same category. " | |
| "Currently, all ghost cells need to have the same category, " | |
| "but got " + std::to_string(cell_vectorization_categories[cell]) + | |
| " and " + std::to_string(cell_vectorization_categories[n_active_cells]) | |
| + "." |
I find these kinds of assertions tremendously easier during debugging if I see the value of the numbers that did not compare equal.
peterrum
force-pushed
the
mf_ghost_categories
branch
from
da237c2
to
fe5f3d7
Compare
bangerth
approved these changes
Jun 18, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
MatrixFree: improve assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.