Work around a GCC-12 warning about array accesses. #14029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are happy with this fix then I will cherry-pick onto 9.4. |
peterrum
approved these changes
Jun 21, 2022
kronbichler
approved these changes
Jun 21, 2022
tjhei
approved these changes
Jun 21, 2022
drwells
commented
Jun 21, 2022
| static const ndarray<unsigned int, 3, 2> table = { | ||
| {{{0, 0}}, {{0, 1}}, {{1, 1}}}}; | ||
| static const ndarray<unsigned int, 6, 2> table = { | ||
| {{{0, 0}}, {{0, 1}}, {{1, 1}}, {{X, X}}, {{X, X}}}}; |
There was a problem hiding this comment.
I just noticed that this has 5, not 6, entries. I'll push a patch.
I'm surprised ndarray lets us do this.
This only occurs at higher optimization levels with -Warray-bounds.
drwells
force-pushed
the
gcc12-array-warning
branch
from
ee19ba0
to
3a393d8
Compare
masterleinad
approved these changes
Jun 21, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the warning in #13910 (comment)
This only occurs at higher optimization levels with
-Warray-bounds.