HDF XDMF entry: store reference cell #14056
Conversation
| * Deprecated constructor. | ||
| * | ||
| * @deprecated Use the constructor that additionally takes a ReferenceCell. | ||
| */ |
There was a problem hiding this comment.
| */ | |
| */ | |
| DEAL_II_DEPRECATED_EARLY |
or the other one.
source/base/data_out_base.cc
Outdated
| default: | ||
| AssertThrow(false, ExcMessage("Invalid dimension")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we move this logic into a helper function and call it directly in the other ctor?
I can do that, but these are mostly internal functions I would think so I thought deprecating directly is ok.
I only thought about this a bit, but it requires quite some work:
Regarding this PR: I would think we would have a type of xdmf entry for mixed meshes (maybe using cell_type=invalid) which writes the correct information. |
|
If its internal we can deprecate it normally. Thanks for checking the mixed mesh situation - it sounds like we should deal with it later. |
It is certainly non-trivial, but I can not promise that we need to change things this PR touches. |
We added support for XDMF output of simplices in #10852 but ended up not storing the type of cell inside the XDMF entry but rely on passing it in after the fact. I think this is a mistake, so I am adding it here.
This is required for my upcoming fix for #13404