DoFAccessor: Streamline access to dof indices #14063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
force-pushed
the
improve_access_to_dofs
branch
from
80f0dbf
to
d9a16b2
Compare
kronbichler
force-pushed
the
improve_access_to_dofs
branch
from
d9a16b2
to
5453301
Compare
This was referenced Jun 28, 2022
drwells
approved these changes
Jun 28, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
DoFAccessor: Streamline access to dof indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #2000, this PR does three related things:
FE::n_dofs_per_objectis larger than 1, rather than forcing the compiler to deduce these properties. Note that sometimes the compiler is able to make these deductions by itself (when we do not write data anywhere, so no possible pointer aliasing), but often it is not. This is similar to a change used in DoFHandlerPolicy: Speed up function renumber_face_mg_dofs #14051.process_objectfunction to get all code in one place, and make it work with the pointers rather than some additional index for better code generation.get_dof_indicesandget_mg_dof_indicesto thedof_accessor.ccfile, because we do not want to generate the code stepping through all objects every time we call those functions. This is a big function anyway, so it is best done there.