p:d:GridRefinement: accept other types of triangulations

[peterrum]

FYI @mschreter

[marcfehling]

Can you add a dynamic_cast check for parallel::DistributedTriangulationBase?

For Triangulation and parallel::shared::Triangulation we have the normal GridRefinement namespace.

[peterrum]

Can you add a dynamic_cast check for parallel::DistributedTriangulationBase?
For Triangulation and parallel::shared::Triangulation we have the normal GridRefinement namespace.

As far as I see it, the functions are working for any triangulation. So I don't want to add a check. Furthermore, I see this more as a first step to move make these functions part of the normal namespace.

[marcfehling]

As far as I see it, the functions are working for any triangulation. So I don't want to add a check. Furthermore, I see this more as a first step to move make these functions part of the normal namespace.

Yes, they should work for any Triangulation. I use some of the functionality also in the hp::Refinement namespace.

[marcfehling]

/jenkins/workspace/dealii_PR-14072/source/distributed/grid_refinement.cc:108:44: error: ‘const class dealii::Triangulation<2, 3>’ has no member named ‘n_locally_owned_active_cells’
     Assert(locally_owned_indicators.size()

[marcfehling]

I assume you want to use this functionality in the context of parallel::shared::Triangulation? Let's wait on more feedback to #14073 (comment) before merging this patch...

[peterrum]

I assume you want to use this functionality in the context of parallel::shared::Triangulation? Let's wait on more feedback to #14073 (comment) before merging this patch...

No that one is unrelated.

[kronbichler]

The initial comment of this function still says Like dealii::GridRefinement::refine_and_coarsen_fixed_number, but for parallel distributed triangulations. - I am wondering if we can use a simpler-to-recognize name, e.g. Like dealii::GridRefinement::refine_and_coarsen_fixed_number, but designed for parallel computations. Together with the rest of the description, this would seem to be more accurate.

[peterrum]

I am have made the changes. I also have added the information what parallel means here.

[kronbichler]

Looks good otherwise.