Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tools project 1 #14101

Merged
merged 1 commit into from Aug 2, 2022
Merged

Vector tools project 1 #14101

merged 1 commit into from Aug 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2022

Fix some minor consistency issues in vector_tools_project.templates.h. This is a part of #12699, which does not change the functionality. Currently I work for #14069, which implies changes in vector_tools_project.templates.h too. But this will be a separated PR.

Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup work!

include/deal.II/numerics/vector_tools_project.templates.h Outdated Show resolved Hide resolved
include/deal.II/numerics/vector_tools_project.templates.h Outdated Show resolved Hide resolved
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the suggestions! Would you squash the commits in this PR as a final step?

@ghost
Copy link
Author

ghost commented Aug 2, 2022

Thanks for addressing the suggestions! Would you squash the commits in this PR as a final step?

Yes, of course, Now it is squashed and rebased.

@marcfehling marcfehling merged commit 6f875cf into dealii:master Aug 2, 2022
@ghost ghost deleted the vector_tools_project_1 branch August 2, 2022 13:32
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant