DoFHandlerPolicy: Avoid one write access to an array #14114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
approved these changes
Jul 12, 2022
| { | ||
| Assert(all_constrained_indices.size() == dim, ExcInternalError()); | ||
|
|
There was a problem hiding this comment.
The only reason we had a dim template argument and passed in a DoFHandler was to ensure this size. Now I changed this to not pass in the unnecessary DoFHandler argument. It felt silly to pass in dim instead just to get the assertion working. As this is an internal interface I can't see that this assertion would help in detecting some bugs. If you want, I can add the check at the place we call this function.
masterleinad
approved these changes
Jul 18, 2022
bangerth
approved these changes
Jul 19, 2022
|
I might not have understood every detail of the patch, but this path is tested in many hundreds if not thousands of tests, so this must be correct to pass the CI suite. |
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
…ation DoFHandlerPolicy: Avoid one write access to an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a similar technique as in #14080: While computing the index offset for the parallel numbering, we do not yet need to set numbers. This can be done after the
MPI_Exscan.