MatrixFree DoFInfo: Break out from some expensive loops #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
commented
Jul 8, 2022
Comment on lines
+722
to
+724
| for (const unsigned int *indices = dof_indices; | ||
| indices != dof_indices + ndofs; | ||
| ++indices) |
There was a problem hiding this comment.
Note that I could also break out of this loop, but the break here is a very unlikely case, so I consider it more expensive to add a check than continuing. Of course, if we want code symmetry we might still consider having it here as well.
masterleinad
approved these changes
Jul 18, 2022
bangerth
approved these changes
Jul 20, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
…_loops MatrixFree DoFInfo: Break out from some expensive loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not super expensive, but enough to be noticed, so we should not continue outer loops when we already breaked inside a nested loop.