Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tria::has_hanging_nodes for anisotropically refined meshes #14150

Merged
merged 3 commits into from Jul 28, 2022

Conversation

luca-heltai
Copy link
Member

Anisotropic refined meshes do not give the correct answer for calls to has_hanging_nodes().

Working on a fix.

@peterrum
Copy link
Member

References #13623.

@luca-heltai
Copy link
Member Author

There might be a faster way, but this is only used in the anisotropic case, in serial, so for the moment, until it becomes critical in some applications, we could live with this slow fix.

@drwells
Copy link
Member

drwells commented Jul 19, 2022

Actually, on second thought - do we permit anisotropic refinement with p::s::T? If so we will need to do a reduction at the end.
update: I checked and the override of this function in DistributedTriangulationBase is probably wrong for p::s::T. We can deal with that later.

edit: perhaps we can cache this value in NumberCache?

@luca-heltai
Copy link
Member Author

~Actually, on second thought - do we permit anisotropic refinement with p::s::T?

If it is shared, all processors will return the same value anyway.

edit: perhaps we can cache this value in NumberCache?

Yes. Maybe in a followup PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants