MatrixFree: Use separate data arrays for two separate evaluators #14153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Jul 20, 2022
kronbichler
force-pushed
the
separate_array
branch
from
9ee27c4
to
9688af2
Compare
|
Right, I didn't realize this. 😉 |
tjhei
approved these changes
Jul 20, 2022
bangerth
approved these changes
Jul 20, 2022
masterleinad
approved these changes
Jul 20, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
MatrixFree: Use separate data arrays for two separate evaluators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14152 (comment), we should use two separate arrays for two evaluators. Their use does not overlap, so the old code was not wrong, but if we decide to re-allocate memory on the second evaluator for some reason in the future, the first one will have pointers to free'd memory.