Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: remove find_package override #14158

Merged
merged 2 commits into from Jul 25, 2022
Merged

CMake: remove find_package override #14158

merged 2 commits into from Jul 25, 2022

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jul 23, 2022

Closes #14065

@tamiko
Copy link
Member Author

tamiko commented Jul 23, 2022

@mathsen Would you mind verifying quickly that this change (i.e., removing the FIND_PACKAGE macro wrapper) fixes the problem?

@tamiko
Copy link
Member Author

tamiko commented Jul 23, 2022

/rebuild

@mathsen
Copy link
Contributor

mathsen commented Jul 24, 2022

@tamiko Thanks for the quick fix - I can confirm that this commit fixes the spack build issue for me.

@tjhei
Copy link
Member

tjhei commented Jul 25, 2022

Does this have any consequences for any of our dependencies?

@tamiko
Copy link
Member Author

tamiko commented Jul 25, 2022

@tjhei I don't think so. It will make manual overrides a bit more difficult. But in retrospect - I think introducing this override had been a bad idea.

On a related note, I think it is time to modernize our dependency setup anyway (to use proper import targets for everything) and this macro would have probably been removed in that process anyway.

@tjhei tjhei merged commit d1475a1 into dealii:master Jul 25, 2022
@jppelteret
Copy link
Member

A bit late, but many thanks for fixing this @tamiko! And thank you for the detective work in #14065 @mathsen and @RichardYCJ.

@bergbauer bergbauer mentioned this pull request Aug 24, 2022
Merged
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
@tjhei
Merge pull request dealii#14158 from tamiko/remove_find_package_override
c6f8651 
CMake: remove find_package override
@tamiko tamiko deleted the remove_find_package_override branch November 30, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

@masterleinad masterleinad masterleinad approved these changes

@drwells drwells drwells approved these changes

Assignees
No one assigned
Labels
Build system ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration: Checking for parallel HDF5 fails
6 participants
@tamiko @mathsen @tjhei @jppelteret @masterleinad @drwells