Add second version of TensorProductMatrixSymmetricSum::apply_inverse() #14178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
requested changes
Aug 7, 2022
| /** | ||
| * Same as above but the user can provide a user-owned temporal array, | ||
| * resolving the two issues described above. | ||
| */ |
There was a problem hiding this comment.
It looks like the temporary array needs to be of length 2 * n: could you document that here?
There was a problem hiding this comment.
The array is set to the right size internally.
There was a problem hiding this comment.
Got it. Could we document that instead? We typically require that users set output arrays to the right sizes so we should clarify what to do for work arrays.
peterrum
force-pushed
the
apply_inverse_tmp
branch
from
34f1ddb
to
2300115
Compare
drwells
approved these changes
Aug 8, 2022
kronbichler
reviewed
Aug 12, 2022
kronbichler
approved these changes
Aug 12, 2022
peterrum
force-pushed
the
apply_inverse_tmp
branch
from
2300115
to
8e3533f
Compare
|
@kronbichler Updated! |
|
We run into timeouts for some tests affected by this: Can you take a look? |
peterrum
force-pushed
the
apply_inverse_tmp
branch
from
8e3533f
to
baef48f
Compare
|
@kronbichler Should be fixed now. I din't move the mutex but duplicated it. So that the code dead locked. |
drwells
approved these changes
Aug 18, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Add second version of TensorProductMatrixSymmetricSum::apply_inverse()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.