Fix Manifold<3, 3>::normal_vector #14183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Aug 10, 2022
| * to the triangulation. | ||
| * | ||
| * In 2d, all manifold ids are set to zero, and a SphericalManifold is | ||
| * attached to the triangulation. In 3d, only the manifold id of the curved |
There was a problem hiding this comment.
Why is this different in 2d? I would think there are also flat faces in 2d!
There was a problem hiding this comment.
Then we may also need to fix quarter_hyper_shell()?
dealii/source/grid/grid_generator.cc
Line 6313 in d7aca55
There was a problem hiding this comment.
I would think so. Can you try to address that as well and see what happens?
There was a problem hiding this comment.
If we remove the spherical manifold on the flat surface, the mesh quality there gets worse as we refine the mesh, as discussed here #14176
masterleinad
requested changes
Sep 2, 2022
zjiaqi2018
force-pushed
the
fix-3d-half_hyper_shell-manifold
branch
from
873f712
to
03e99f0
Compare
|
It should work now, @tjhei @luca-heltai |
tjhei
approved these changes
Sep 20, 2022
|
Can you add a changelog and update the text of the PR (when you scroll up here)? |
luca-heltai
approved these changes
Sep 20, 2022
luca-heltai
added
Reviewed and ready to merge
and removed
Do not merge ☠️
Reviewed and ready to merge
labels
zjiaqi2018
changed the title
masterleinad
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14176
On very coarse meshes, with very particular manifolds, e.g., spherical manifold, polar manifolds, cylindrical manifolds, etc,
Manifold<3, 3>::normal_vectormay return a zero vector. This issues can be fixed by choosing different combinations of vertices to compute the normal vector.