Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilinos utilities #14191

Merged
merged 2 commits into from Aug 18, 2022
Merged

Trilinos utilities #14191

merged 2 commits into from Aug 18, 2022

Conversation

drwells
Copy link
Member

@drwells drwells commented Aug 16, 2022

More work on #13949 - we should avoid including Trilinos headers outside of Trilinos-specific files.

@drwells
Copy link
Member Author

drwells commented Aug 16, 2022

/rebuild

Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me that you basically move code around.

Introducing trilinos_utilities.h might break some user code if they use the Utilities::Trilinos namespace. Could you also add a changelog?

@drwells
Copy link
Member Author

drwells commented Aug 16, 2022

Fixed!

@drwells
Copy link
Member Author

drwells commented Aug 17, 2022

Let me rebase this and check with tpetra before we merge to avoid a problem like #14192/#14194.

@marcfehling marcfehling merged commit 283e29f into dealii:master Aug 18, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants