Fix MatrixFree + FE_Q_iso_Q1(2) #14197
Conversation
| shape_info.element_type <= | ||
| MatrixFreeFunctions::tensor_symmetric_no_collocation) | ||
| FEFaceEvaluationImpl<true, |
There was a problem hiding this comment.
Isn't this branch also using collocation derivatives:
dealii/include/deal.II/matrix_free/evaluation_kernels.h
Lines 2533 to 2534 in 2d6e494
Hence, I believe we need to use
tensor_symmetric here and in the other face function below.
| @@ -5174,7 +5178,7 @@ namespace internal | |||
| { | |||
| Assert(fe_degree > -1, ExcInternalError()); | |||
| Assert(fe_eval.get_shape_info().element_type <= | |||
| MatrixFreeFunctions::tensor_symmetric, | |||
| MatrixFreeFunctions::tensor_symmetric_no_collocation, | |||
There was a problem hiding this comment.
Here, I think we also need to play safe and only enable it for the tensor_symmetric case.
| if (dynamic_cast<const FE_Q_iso_Q1<dim> *>(&fe)) | ||
| element_type = tensor_symmetric_no_collocation; |
There was a problem hiding this comment.
I would prefer if we could move this above the if statement for check_1d_shapes_collocation, because we should not even build the matrices for that case.
|
You would need to adjust the output of |
I am working on that and on an additional test, which performs a sanity test. |
peterrum
force-pushed
the
FE_Q_iso_Q1_2_MF
branch
from
d15d4ec
to
fec0d10
Compare
|
@kronbichler I have applied the suggested changes, modified the test output and added a new test, which tests the influence of dofs on quadrature point values/gradient (a sanity check I used to debug the problem). |
peterrum
changed the title
Fix MatrixFree + FE_Q_iso_Q1(2)
No description provided.