Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adolc tensor refactor #14205

Closed
wants to merge 6 commits into from
Closed

Adolc tensor refactor #14205

wants to merge 6 commits into from

Commits on Aug 23, 2022

  1. Fix abs() return types in l1_norm() and linfty_norm().

    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1675bc6 View commit details
    Browse the repository at this point in the history

  2. Combine both implementations of l1_norm() and linfty_norm().

    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    db0906f View commit details
    Browse the repository at this point in the history

  3. Actually test the l1_norm() and linfty_norm() with adol-c.

    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    cf015cc View commit details
    Browse the repository at this point in the history

  4. Remove unused headers.

    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1f85371 View commit details
    Browse the repository at this point in the history

  5. Delete an unnecessary check for adol-c. 

    This works correctly with advanced branching.
    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    bbd2e45 View commit details
    Browse the repository at this point in the history

  6. Clean up a test. 

    This test should always pass now, regardless of how adol-c is set up.
    @drwells
    drwells committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    efe392b View commit details
    Browse the repository at this point in the history