Specialize EvaluatorTensorProduct<evaluate_evenodd> for non-templated execution #14237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
commented
Sep 3, 2022
Comment on lines
+1580
to
+1581
| inline void | ||
| even_odd_apply(const int n_rows_in, |
There was a problem hiding this comment.
I made this to free function, since ...
Comment on lines
1952
to
1964
| static void | ||
| apply(const Number2 *DEAL_II_RESTRICT shape_data, |
There was a problem hiding this comment.
... the "old" apply function is static, which does not work for the non-templated case, where we pass in the bounds via the constructor.
kronbichler
reviewed
Sep 3, 2022
| { | ||
| for (int i1 = 0; i1 < n_blocks1; ++i1) | ||
| { | ||
| Number xp[mid > 0 ? mid : 1], xm[mid > 0 ? mid : 1]; |
There was a problem hiding this comment.
Does this work? This would create a variable-sized array, which is (IIRC) a GNU extension.
There was a problem hiding this comment.
You are right. I am a bit surprised that I did not get a warning. I have pushed a fix.
peterrum
force-pushed
the
even_odd_apply
branch
from
fdfae7c
to
8e6e6eb
Compare
|
/rebuild |
kronbichler
approved these changes
Sep 6, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Specialize EvaluatorTensorProduct<evaluate_evenodd> for non-templated execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.